Skip to content

[skip changelog] Add documentation for Settings service #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2020
Merged

[skip changelog] Add documentation for Settings service #678

merged 1 commit into from
May 8, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Apr 28, 2020

Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce?

Add explanatory comments for the Settings service gRPC interface to the source code. These comments will be included in the generated gRPC interface documentation.

  • What is the current behavior?

There is very little explanation of the gRPC interface in the documentation.

  • What is the new behavior?

Improved documentation of the Settings service interface.

  • Does this PR introduce a breaking change?

No

  • Other information:

Generated docs:
https://per1234.github.io/arduino-cli/rpc/settings/

Comments added to the .proto files are included in the generated gRPC interface documentation.
@per1234 per1234 added topic: documentation Related to documentation for the project component/gRPC labels Apr 28, 2020
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@per1234 per1234 merged commit a2adf31 into arduino:master May 8, 2020
@per1234 per1234 deleted the settings-service-documentation branch May 13, 2020 01:48
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants